More icons! #1249
Closed
More icons! #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are some great quality badge icons, I hope they're good enough to hold us over until someone who knows what they're doing can make better ones.
Contributor
|
Don't think this is going to work the way you think |
Contributor
Author
|
uh, did I screw something up here? |
imkylecat
reviewed
Dec 28, 2024
| } | ||
|
|
||
| if (body.new_password) { | ||
| if (!body.password && !user.email) { |
Contributor
Author
There was a problem hiding this comment.
seems I had screwed up something with git, that's an old change, this pull request is dead anyhow, apparently this is the wrong spot for these assets, and currently there's no real correct spot for them either. No idea why that's there. I don't remember what exactly this does, but it looks to be changing users who exist not needing to enter their password while those who don't not needing to, to users that exist needing to enter their password and users that don't needing not to.
Contributor
Author
|
yeah, this is not at all correct, spacebar has some weirdness, who knows where these should go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are great:tm: icons. I hope these get replaced soon lol